Skip to content

Conversation

@wjoosen
Copy link
Contributor

@wjoosen wjoosen commented Oct 26, 2025

This PR prepares for the soon to be released DVR switching changes, which have very limited effect on the public APIs. For Web and Android they introduce a new optional field millicastSrc in a TheoLiveEndpoint.

The necessary bridging for Android and types were added.

For iOS millicastSrc is not included in the EndpointAPI.

‼️version 10.4.0 of the native player SDK is required for these changes to work

@tvanlaerhoven tvanlaerhoven self-requested a review October 27, 2025 10:10
@tvanlaerhoven
Copy link
Member

Note: native Android v10.4.0 is needed for this

@Yousif-CS
Copy link

I don't believe the millicast subscriber token should be added here. @GillesMoris-Dolby @turbidwater @RameshDPrasad since auth token is consumed via the theolive API instead, we shouldn't add that field here. Correct me if I am wrong.

@turbidwater
Copy link

@wjoosen @Yousif-CS For what it's worth, in Web we're adding it this way, where it prefers the information from the theoLive.authToken field, but also could accept it from the discovery response:
subscriberToken: this._authToken ?? endpoint.millicastSrc.subscriberToken

@tvanlaerhoven tvanlaerhoven self-requested a review November 13, 2025 08:05
@tvanlaerhoven tvanlaerhoven force-pushed the feature/millicast-dvr-switching branch from 0e2c752 to 6c9a532 Compare November 13, 2025 08:12
@tvanlaerhoven
Copy link
Member

I think it looks OK as it is now, we are just passing an API object here:

For Android, the EndpointMillicastSource object is simply being passed, similarly to Web, where unfortunately it's called ChannelMillicastSource, but the interface is the same.

@Yousif-CS @wjoosen @turbidwater could you check again?

@wjoosen
Copy link
Contributor Author

wjoosen commented Nov 13, 2025

I only just noticed we ended up exposing the millicastSrc on iOS too. I'll make the necessary changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants