-
Notifications
You must be signed in to change notification settings - Fork 29
Feature/millicast dvr switching #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Note: native Android v10.4.0 is needed for this |
|
I don't believe the millicast subscriber token should be added here. @GillesMoris-Dolby @turbidwater @RameshDPrasad since auth token is consumed via the theolive API instead, we shouldn't add that field here. Correct me if I am wrong. |
|
@wjoosen @Yousif-CS For what it's worth, in Web we're adding it this way, where it prefers the information from the |
0e2c752 to
6c9a532
Compare
|
I think it looks OK as it is now, we are just passing an API object here: For Android, the EndpointMillicastSource object is simply being passed, similarly to Web, where unfortunately it's called ChannelMillicastSource, but the interface is the same. @Yousif-CS @wjoosen @turbidwater could you check again? |
|
I only just noticed we ended up exposing the |
This PR prepares for the soon to be released DVR switching changes, which have very limited effect on the public APIs. For Web and Android they introduce a new optional field
millicastSrcin aTheoLiveEndpoint.The necessary bridging for Android and types were added.
For iOS
millicastSrcis not included in the EndpointAPI.